Make sure lint results follow phab api specs #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@sectioneight @kageiit |
kageiit
suggested changes
Dec 8, 2016
| (Integer) json.get("line"), | ||
| (Integer) json.get("char"), | ||
| line == null ? null : (Integer) line, | ||
| charPosition == null ? null : (Integer) charPosition, | ||
| (String) json.get("description"))); |
There was a problem hiding this comment.
description is optional as well
kageiit
suggested changes
Dec 8, 2016
| String code = (String) json.get("code"); | ||
| String severity = (String) json.get("severity"); | ||
| String path = (String) json.get("path"); | ||
| Integer line = (Integer) json.opt("line"); |
There was a problem hiding this comment.
This will NPE because you are trying to typecast null to Integer
kageiit
suggested changes
Dec 8, 2016
kageiit
suggested changes
Dec 8, 2016
| assertEquals(results.code, "_code"); | ||
| assertEquals(results.severity, "error"); | ||
| assertEquals(results.path, "foobar.java"); | ||
| assertTrue(results.line == null); |
There was a problem hiding this comment.
we should not even be sending these fields if they are null
There was a problem hiding this comment.
Wait I think this does what its supposed to. nvm :)
kageiit
approved these changes
Dec 8, 2016
| assertEquals(results.code, "_code"); | ||
| assertEquals(results.severity, "error"); | ||
| assertEquals(results.path, "foobar.java"); | ||
| assertTrue(results.line == null); |
There was a problem hiding this comment.
Wait I think this does what its supposed to. nvm :)
kageiit
suggested changes
Dec 8, 2016
| String path = (String) json.get("path"); | ||
| Integer line = (Integer) json.opt("line"); | ||
| Integer charPosition = (Integer) json.opt("char"); | ||
| String description = (String) json.get("description"); |
There was a problem hiding this comment.
opt here. description is optional according to spec
kageiit
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phab API specs does not require these 2 params. By forcefully casting the object we get back from json, we are inherently enforcing requirement.