Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first test to the project #37

Merged
merged 3 commits into from
Jun 28, 2015
Merged

Add first test to the project #37

merged 3 commits into from
Jun 28, 2015

Conversation

ascandella
Copy link
Contributor

Also enable coveralls.

References #6

@ascandella ascandella force-pushed the start-testing branch 2 times, most recently from 7821081 to 84ba05e Compare June 28, 2015 01:15
@ascandella
Copy link
Contributor Author

@jjx

Also enable coveralls.
@Rule
public JenkinsRule j = new JenkinsRule();

Map<String, String> emptyParams = new HashMap<String, String>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this private static final

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jjx
Copy link
Contributor

jjx commented Jun 28, 2015

lgtm!

@ascandella
Copy link
Contributor Author

8.47% is pretty 💩 but at least better than 0 :\

ascandella added a commit that referenced this pull request Jun 28, 2015
Add first test to the project
@ascandella ascandella merged commit fd0131a into master Jun 28, 2015
@ascandella ascandella deleted the start-testing branch June 28, 2015 02:56
ascandella added a commit to jenkinsci/phabricator-plugin that referenced this pull request Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants