Refactor PhabricatorNotifier comment builder #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascandella
force-pushed
the
refactor-commenter
branch
from
6d4310a
to
c2dcdf0
Compare
Instead of having one heaping class that's responsible for a bunch of business logic, breaking out the comment building and code coverage comparison into a self-contained class that is easier to test and understand. Future refactors will break down the Notifier even further, but this is one atomic piece of work that can go in. Additionally, fixed a bug in the TestUtils default coverage data, which was off by 100x for cobertura results (since cobertura the plugin returns them as floats from 0-1)
ascandella
force-pushed
the
refactor-commenter
branch
from
c2dcdf0
to
345ef8b
Compare
|
BTW, we're now finally >50% coverage (51%), so I'm considering adding the coveralls badge to remind me to keep going... |
| * @return | ||
| */ | ||
| public boolean hasCoverageAvailable() { | ||
| if (currentCoverage == null) { |
There was a problem hiding this comment.
Can simplify this to:
return currentCoverage != null && currentCoverage.getCoverage(CoverageMetric.LINE) != null;
There was a problem hiding this comment.
Good call. Done.
| } | ||
| } else { | ||
| logger.info("uberalls", "no line coverage found, skipping..."); | ||
| } | ||
|
|
||
| if (build.getResult().isBetterOrEqualTo(Result.SUCCESS)) { |
There was a problem hiding this comment.
Can we just remove this entire thing and set the flag when the variable is instantiated?
There was a problem hiding this comment.
Awesome. Really appreciate your fine-toothed-comb reviews :D
|
👍 |
ascandella
added a commit
that referenced
this pull request
Jul 20, 2015
Refactor PhabricatorNotifier comment builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having one heaping class that's responsible for a bunch of
business logic, breaking out the comment building and code coverage
comparison into a self-contained class that is easier to test and understand.
Future refactors will break down the Notifier even further, but this is
one atomic piece of work that can go in.
Additionally, fixed a bug in the TestUtils default coverage data, which
was off by 100x for cobertura results (since cobertura the plugin
returns them as floats from 0-1)