Fix go comments bug

uber · Feb 23, 2023 · 815a0f5 · 815a0f5
1 parent 8f2231f
commit 815a0f5
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 1 deletion.
diff --git a/test-resources/go/feature_flag/builtin_rules/statement_cleanup/input/sample.go b/test-resources/go/feature_flag/builtin_rules/statement_cleanup/input/sample.go
@@ -115,7 +115,7 @@ func simplify_if_statement_false_comment_demo_single_comment() {
         fmt.Println("remain")
     }
     // this comment doesnt get removed but it should
-    if exp1.BoolValue("false") {
+    if exp.BoolValue("false") {
         fmt.Println("to be removed 2")
     }
 }

diff --git a/test-resources/java/feature_flag_system_1/control/expected/XPFlagCleanerPositiveCases.java b/test-resources/java/feature_flag_system_1/control/expected/XPFlagCleanerPositiveCases.java
@@ -74,6 +74,10 @@ public void complex_conditional_contains_stale_flag(boolean tBool) {
     }
   }
 
+  public void check_comment_cleanup(){
+    System.out.println("Hellow World!");
+  }
+
   public void other_api_stale_flag() {
 
     System.out.println("Hi world");

diff --git a/test-resources/java/feature_flag_system_1/control/input/XPFlagCleanerPositiveCases.java b/test-resources/java/feature_flag_system_1/control/input/XPFlagCleanerPositiveCases.java
@@ -94,6 +94,14 @@ public void complex_conditional_contains_stale_flag(boolean tBool) {
     }
   }
 
+  public void check_comment_cleanup(){
+    System.out.println("Hellow World!");
+    // Should be deleted
+    if (experimentation.isFlagTreated(TestExperimentName.STALE_FLAG)) {
+      System.out.println("Hello World");
+    }
+  }
+
   public void other_api_stale_flag() {
 
     if (experimentation.isFlagTreated(TestExperimentName.STALE_FLAG)) {

diff --git a/test-resources/kt/feature_flag_system_2/treated/expected/XPFlagCleanerInterfaceMethod.kt b/test-resources/kt/feature_flag_system_2/treated/expected/XPFlagCleanerInterfaceMethod.kt
@@ -93,4 +93,8 @@ internal class XPFlagCleanerPositiveCases {
             println("Hi world")
         }
     }
+
+    fun check_comments(a: Int, z: Int) {
+        println("Hello World!")
+    }
 }
diff --git a/test-resources/kt/feature_flag_system_2/treated/input/XPFlagCleanerInterfaceMethod.kt b/test-resources/kt/feature_flag_system_2/treated/input/XPFlagCleanerInterfaceMethod.kt
@@ -135,4 +135,12 @@ internal class XPFlagCleanerPositiveCases {
             println("Hi world")
         }
     }
+
+    fun check_comments(a: Int, z: Int) {
+        println("Hello World!")
+        // Should be deleted!
+        if (!experimentation.isStaleFeature().cachedValue) {
+            println("Hello World")
+        }
+    }
 }