Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the directory to polyglot #197

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Rename the directory to polyglot #197

merged 6 commits into from
Jun 22, 2022

Conversation

ketkarameya
Copy link
Collaborator

This PR renames the directory from generic to polyglot. It propagates this rename to readmes, ci jobs and other files.

@ketkarameya ketkarameya reopened this Jun 22, 2022
lazaroclapp
lazaroclapp approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this just moves code around and renames references, so it LGTM (Also, I really don't have much context on Polyglot Piranha anymore). Added a brief note about files not ending in new line, which is generally not recommended.

.github/workflows/rust.yml Outdated
working-directory: polyglot/piranha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this file doesn't end in a newline?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

.gitignore Outdated
polyglot/piranha/demo/piranha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@ketkarameya ketkarameya merged commit bae2449 into uber:master Jun 22, 2022
@ketkarameya ketkarameya deleted the rename-to-polyglot branch July 10, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazaroclapp lazaroclapp lazaroclapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ketkarameya @lazaroclapp