Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Cleanup Built-in Rules #265

Merged
merged 56 commits into from
Dec 19, 2022
Merged

Go Cleanup Built-in Rules #265

merged 56 commits into from
Dec 19, 2022

Commits on Dec 18, 2022

  1. Pointing to modified Go grammar for now

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    872687c View commit details
    Browse the repository at this point in the history

  2. Go: Initial boolean_expression_simplify rules

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fb8e013 View commit details
    Browse the repository at this point in the history

  3. Unary_expression has "hidden" field operator 

    - It does not show when parsing, but it's present in the grammar
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    bf726c1 View commit details
    Browse the repository at this point in the history

  4. Go: simplify {true|false}_and_something...

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    3833c4e View commit details
    Browse the repository at this point in the history

  5. Go: simplify {true|false} or something...

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    769ba90 View commit details
    Browse the repository at this point in the history

  6. Go: converging to a standard rule formatting

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fee496d View commit details
    Browse the repository at this point in the history

  7. Go: if_cleanup && remove_unneccessary_nested_block

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    8acc48d View commit details
    Browse the repository at this point in the history

  8. Go: TODO comment to address if w/ short stmt

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    215f11d View commit details
    Browse the repository at this point in the history

  9. Go: temp start for delete_short_v_decl

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    3e4e10f View commit details
    Browse the repository at this point in the history

  10. 'delete_immediate_if_err' working. clean rules/edges/scope later

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    b2b0674 View commit details
    Browse the repository at this point in the history

  11. replace_double_short_var_decl working!

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    f4d9bac View commit details
    Browse the repository at this point in the history

  12. delete_variable_declaration

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    51500e1 View commit details
    Browse the repository at this point in the history

  13. One intra cleanup scenario working!

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    eb85d56 View commit details
    Browse the repository at this point in the history

  14. Merging two rules into one

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    6cb92ed View commit details
    Browse the repository at this point in the history

  15. Fix hole; Scope Function -> Function-Method

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    a9530c5 View commit details
    Browse the repository at this point in the history

  16. Adding graph for current built-in rules

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    8e85e59 View commit details
    Browse the repository at this point in the history

  17. Go: constant same file

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    e086048 View commit details
    Browse the repository at this point in the history

  18. delete_bool_blank_identifier_short_var_declaration

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    6875fbb View commit details
    Browse the repository at this point in the history

  19. Go: Removing unused param used in call

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    dbc86f7 View commit details
    Browse the repository at this point in the history

  20. Go: delete_all_statements_after_return

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    93d0bf2 View commit details
    Browse the repository at this point in the history

  21. Simplifying identity equality and inequality for {true|false|nil} 

    - `nil == nil` and `nil != nil` is not compilable in go
- however, it compiles in tree-sitter
- we may use it to ease some cleanups
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    02200fa View commit details
    Browse the repository at this point in the history

  22. Go: Cleanup rules work for single short var decl 

    - For now, ignoring `enabled, err := ...` & `enabled, _ := ...`
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    9c89491 View commit details
    Browse the repository at this point in the history

  23. delete_variable_declaration needs a constraint!

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    a0435b5 View commit details
    Browse the repository at this point in the history

  24. replace_identifier_with_value needs a constraint

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    c5de253 View commit details
    Browse the repository at this point in the history

  25. More meaningful names for identity rules

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    d4249aa View commit details
    Browse the repository at this point in the history

  26. Moving Go tests

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    e7276bc View commit details
    Browse the repository at this point in the history

  27. Go delete_statement_after_return self-edge

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fcf2633 View commit details
    Browse the repository at this point in the history

  28. Removing outdated image

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    de9ad4c View commit details
    Browse the repository at this point in the history

  29. --ignore-parser-error option. (rebased so this commit is very weird) 

    - we may tolerate some rewrites that produce parse errors
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    0cefd06 View commit details
    Browse the repository at this point in the history

  30. Reverting ignore_parse_error arg (rebased; commit is weird)

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    ec97026 View commit details
    Browse the repository at this point in the history

  31. Initial cleanup of go rules

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    5ccc4b1 View commit details
    Browse the repository at this point in the history

  32. Go simplify_identity: wildcard for lhs and rhs

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    a6255e2 View commit details
    Browse the repository at this point in the history

  33. Go: test for simplify if false with no alternative

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    d049ed8 View commit details
    Browse the repository at this point in the history

  34. Removing .s from delete_parent_assignment

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    8a24525 View commit details
    Browse the repository at this point in the history

  35. * and + rules with \n terminator 

     - Having the `\n` terminator reproduces the exact matching
  as languages such as Java and JavaScript
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fcb1c48 View commit details
    Browse the repository at this point in the history

  36. Go grammar: branch on Uber tree-sitter-go repo

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    9439bca View commit details
    Browse the repository at this point in the history

  37. return_cleanup <-> delete_stmt_after_return

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    533a1be View commit details
    Browse the repository at this point in the history

  38. Go: removing * from lhs|rhs captures

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    8dba1a2 View commit details
    Browse the repository at this point in the history

  39. constraint for replace_identifier_with_value

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    e2c14ec View commit details
    Browse the repository at this point in the history

  40. simplify_something_or_true excluding calls

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    7dbde04 View commit details
    Browse the repository at this point in the history

  41. simplify_something_and_false excluding calls

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    2fbd662 View commit details
    Browse the repository at this point in the history

  42. Removing 'delete_parent_assignment' !

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    5224867 View commit details
    Browse the repository at this point in the history

  43. Adding Go in PiranhaLanguage

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    189990c View commit details
    Browse the repository at this point in the history

  44. dummy 'return_cleanup' -> 'return_statement_cleanup

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    171d4dc View commit details
    Browse the repository at this point in the history

  45. Simplifying rules for test "const_same_file"

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    7759e90 View commit details
    Browse the repository at this point in the history

  46. const_same_file tests following conventions 

    - `@treated` for flag value
- `groups` in the end of rule definition
- rule that matches first declared first
- `false_flag` -> `update_feature_flag_api`
    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fb72b1f View commit details
    Browse the repository at this point in the history

  47. Removing empty edges.toml

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    9e8faf3 View commit details
    Browse the repository at this point in the history

  48. test_piranha_go: Adding needed import

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    67b509a View commit details
    Browse the repository at this point in the history

  49. Using treated/treated_complement as arguments in test

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    1f93f33 View commit details
    Browse the repository at this point in the history

  50. Fix .toml formatting

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    8cbbe3c View commit details
    Browse the repository at this point in the history

  51. cleaning remove_unnecessary_nested_block

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    0a1d8da View commit details
    Browse the repository at this point in the history

  52. Cleaning delete_statement_after_return

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    bea7f6f View commit details
    Browse the repository at this point in the history

  53. add missing license

    @dvmarcilio
    dvmarcilio committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    4ce2547 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. README: checkmarks for Go

    @dvmarcilio
    dvmarcilio committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    2b584aa View commit details
    Browse the repository at this point in the history

  2. TODO on Cargo.toml to change tree-sitter-go dependency

    @dvmarcilio
    dvmarcilio committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    c8f9942 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into go_develop

    @dvmarcilio
    dvmarcilio committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    f0b1f55 View commit details
    Browse the repository at this point in the history