Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all slow hmc jit tests #1663

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Enable all slow hmc jit tests #1663

merged 2 commits into from
Dec 11, 2018

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Dec 11, 2018 •
edited by neerajprad
Loading

Fixes #1487.

The issue pytorch/pytorch#13669 has been fixed in pytorch release. Now we can enable many failed jit tests of hmc/nuts.

Thanks @apaszke !

neerajprad
neerajprad approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@neerajprad neerajprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge if the tests pass, and the time taken seems reasonable.

fritzo
fritzo requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this PR should not be merged until our CI test run with a version of PyTorch that includes the fixes. Currently our CI tests run with PyTorch 1.0 release, not master. I suggest we hold off or move this PR to a 1.0.1 branch or something.

fritzo
fritzo approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my misunderstanding, I see this is already in PyTorch release.

@neerajprad neerajprad merged commit b501db3 into pyro-ppl:dev Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

@neerajprad neerajprad neerajprad approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trace's log_prob of models with Gamma/Dirichlet distributions incompatible with JIT
3 participants
@fehiepsi @fritzo @neerajprad