Use d3 as a direct dependency. #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vicapow This looks fine. The next major version will be using d3v5, however it currently still uses a peerDependency for it. I will research adding it to dependencies instead. I accept this change. |
|
@vicapow, please rebase and fix conflicts. Please also sign the CLA. |
|
Closing this PR as #58 solved the problem and this contributor hasn't rebased the code or signed the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a few different versions of d3 right now. Adding this as a direct dependency should help and should be safe. Ideally, in the future, we should be using d3 v5 and depending on our individual packages directly instead of the d3 mono package.