Skip to content

Commit

Permalink
Fix Lint
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Thomas committed May 31, 2020
1 parent d42a21e commit a94e834
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/react-vis/src/make-vis-flexible.js
Expand Up @@ -140,7 +140,7 @@ function makeFlexible(Component, isWidthFlexible, isHeightFlexible) {
this.cancelSubscription = subscribeToDebouncedResize(this._onResize);
}

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps, prevState) {
if (
this.state.width !== prevState.width ||
this.state.height !== prevState.height
Expand Down
2 changes: 1 addition & 1 deletion packages/react-vis/src/plot/series/arc-series.js
Expand Up @@ -74,7 +74,7 @@ class ArcSeries extends AbstractSeries {
this.state = {scaleProps};
}

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps) {
if (this.props !== prevProps) {
this.setState({scaleProps: this._getAllScaleProps(this.props)});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-vis/src/plot/xy-plot.js
Expand Up @@ -144,7 +144,7 @@ class XYPlot extends React.Component {
};
}

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps) {
if (this.props !== prevProps) {
const children = getSeriesChildren(this.props.children);
const nextData = getStackedData(children, this.props.stackBy);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-vis/src/treemap/index.js
Expand Up @@ -100,7 +100,7 @@ class Treemap extends React.Component {
};
}

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps) {
if (this.props !== prevProps) {
this.setState({
scales: _getScaleFns(this.props),
Expand Down
6 changes: 4 additions & 2 deletions packages/react-vis/tests/components/heatmap.test.js
Expand Up @@ -30,15 +30,17 @@ describe('Heatmap', () => {
test('basic rendering', () => {
const $ = mount(
<XYPlot width={300} height={300}>
<HeatmapSeries data-foo="original" {...HEATMAP_PROPS} />
<HeatmapSeries data-foo="original" {...HEATMAP_PROPS} />
</XYPlot>
);
expect($.find('.rv-xy-plot__series--heatmap').length).toBe(1);
expect($.find('.rv-xy-plot__series--heatmap rect').length).toBe(12);
expect($.find('g.heatmap-series-example').length).toBe(1);

$.setProps({
children: <HeatmapSeries data-foo="set" {...{...HEATMAP_PROPS, data: null}} />
children: (
<HeatmapSeries data-foo="set" {...{...HEATMAP_PROPS, data: null}} />
)
});
$.update();

Expand Down
Expand Up @@ -102,7 +102,7 @@ class ForceDirectedGraph extends React.Component {
};
}

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps) {
if (this.props !== prevProps) {
this.setState({
data: generateSimulation(this.props)
Expand Down
Expand Up @@ -74,7 +74,7 @@ export default class ResponsiveScatterplot extends React.Component {
selectedPoints: []
};

componentDidUpdate(prevProps, prevState, snapshot) {
componentDidUpdate(prevProps) {
if (this.props !== prevProps) {
this.setState({
binData: transformToBinData(
Expand Down

0 comments on commit a94e834

Please sign in to comment.