Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add className functionality to Hint and GridLines #1008

Merged
merged 3 commits into from Feb 18, 2019
Merged

Add className functionality to Hint and GridLines #1008

merged 3 commits into from Feb 18, 2019

Conversation

sharynneazhar
Copy link
Contributor

Add className prop to Hint and GridLines components.

Resolves #1002.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

mcnuttandrew
mcnuttandrew reviewed Oct 13, 2018
View reviewed changes
Copy link
Contributor

@mcnuttandrew mcnuttandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! Thanks for doing it.

Would you mind writing some tests so that this functionality isn't accidentally erased in the future?

@mcnuttandrew
Copy link
Contributor

@sharynneazhar any update on this?

@sharynneazhar
Copy link
Contributor Author

sharynneazhar commented Feb 14, 2019 •
edited

Sorry @mcnuttandrew! Added the tests to this 🙂

Though, tests may or may not failed relating to issues fixed in this PR #1079.

@mcnuttandrew
Copy link
Contributor

This looks good! Thanks again for doing this, great work

@mcnuttandrew mcnuttandrew merged commit 31e9ec1 into uber:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcnuttandrew mcnuttandrew mcnuttandrew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sharynneazhar @CLAassistant @mcnuttandrew