Add 'sidePadding' property to the treemap #1224
Open
+43
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bi0max
changed the title
|
It seems, that build is failed not because of my changes to the code. |
|
try rebasing off master i think the build should be fixed now |
|
Thank you for letting me know! build works now. |
|
Hi guys, do you plan to merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to have padding only on the top of the treemap, but it was not possible.
It is useful, when one wants the name of the parent to be seen above the children.
Currently, padding applies from all sides and makes all children components significantly smaller.
So, I decided to add a
sidePaddingproperty, so that user can add padding from other sides separately.'sidePadding' property can be safely used with existing 'padding' property.
Before (with padding=20):
After (with padding=3 and sidePadding={'top': 20}):
