Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sankey): add labels support #425

Merged
merged 2 commits into from
May 24, 2017
Merged

feat(sankey): add labels support #425

merged 2 commits into from
May 24, 2017

Conversation

balthazar
Copy link
Contributor

screen shot 2017-05-21 at 12 02 02 am

Display by default the name property of the nodes as labels.
Also provides a hideLabels property, turned off by default

@mcnuttandrew
Copy link
Contributor

Given that this a top level chart type, consider using xyplot and label series to make this happen?

Add tests and docs

Copy link
Contributor

@mcnuttandrew mcnuttandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@balthazar balthazar merged commit cfac278 into master May 24, 2017
@balthazar balthazar deleted the sankey-labels branch May 24, 2017 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants