Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up links on the Showcase Page #764

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Clean up links on the Showcase Page #764

merged 3 commits into from
Mar 27, 2018

Conversation

manassra
Copy link
Contributor

  • Removes the source link: I always found it confusing that we had this link when almost always you want to inspect the example code, not the source code of the underlying series.
  • Styling changes to clean up the remaining two links (view code, and documentation)

Before
image

After
image

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2018

CLA assistant check
All committers have signed the CLA.

@mcnuttandrew
Copy link
Contributor

Looks good. Stamp

@manassra
Copy link
Contributor Author

Thanks for the quick review, @mcnuttandrew!

@manassra manassra merged commit 71116cd into master Mar 27, 2018
@manassra manassra deleted the clean-up-doc-links branch March 27, 2018 00:31
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
* Remove the source link for the showcase components; clean up the view code and documentation links
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
* Remove the source link for the showcase components; clean up the view code and documentation links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants