Correct doc hint.md; "orientation" --> "align" #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "orientation" prop should've been "align", and should be an Object type.
|
@mcnuttandrew - "orientation" didn't work for me, I looked at lab7 for an example, and saw that it should be "align" instead of "orientation" (I think) |
|
Very reasonable. I think the docs were right in spirit (ie they were consistent with the rest of the library), but wrong in practice. I've noted this in this @821 thread. I'll merge this in now and we'll make it correct once it comes true. |
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
The "orientation" prop should've been "align", and should be an Object type.
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
The "orientation" prop should've been "align", and should be an Object type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "orientation" prop should've been "align", and should be an Object type.