Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iris small multiples example #976

Merged
merged 1 commit into from Sep 24, 2018

Conversation

mcnuttandrew
Copy link
Contributor

Did you know we are required by law as an internet charting library to have a small multiples display of the iris data set?

iris

This PR adds a small multiples matrix for the iris dataset i added a little while ago. It provides a nice replacement to the zoom examples.

Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!

const {filters} = this.state;

const data = Iris.map(d => {
const unselected = AXES.some(key => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, .some is underrated

}
const updateFilter = area => {
if (!area) {
filters[xAxis] = {min: null, max: null};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, sort-of don't like that we're mutating filters here - but since this is just an example ¯\_(ツ)_/¯

@mcnuttandrew mcnuttandrew merged commit 9adfad1 into uber:master Sep 24, 2018
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants