Add support for prioritizing SSO Apps #145
Conversation
| @@ -138,7 +151,7 @@ private Uri createSsoUri() { | |||
| @Override | |||
| public boolean isSupported() { | |||
| return appProtocol.isInstalled(activity, UBER, MIN_UBER_RIDES_VERSION_SUPPORTED) | |||
| || appProtocol.isInstalled(activity, UBER_EATS, MIN_UBER_EATS_VERSION_SUPPORTED); | |||
| || appProtocol.isInstalled(activity, UBER_EATS, MIN_UBER_EATS_VERSION_SUPPORTED); | |||
There was a problem hiding this comment.
I think this has to fork based on productFlowPriority. Otherwise, you could get false positives. For example if the user has rides installed, but their productFlowPriority contains eats but not rides, then the deeplink would say SSO is supported even though it is not.
|
|
||
| if(!validatedPackages.isEmpty()) { | ||
| if (!validatedPackages.isEmpty()) { | ||
| intent.setPackage(validatedPackages.get(0).packageName); | ||
| } | ||
| activity.startActivityForResult(intent, requestCode); |
There was a problem hiding this comment.
I know this was here before, do we still want this behavior? My intuition says that we should not be executing the intent if we didn't manage to validate that they have the expected app versions installed
@tyvsmith any thoughts on this?
There was a problem hiding this comment.
If there are two and we don't specify one, it'll show the intent picker which is a bad UX. If there are 0, it would have failed at the beginning of the method.
|
|
||
| if(!validatedPackages.isEmpty()) { | ||
| if (!validatedPackages.isEmpty()) { | ||
| intent.setPackage(validatedPackages.get(0).packageName); | ||
| } | ||
| activity.startActivityForResult(intent, requestCode); |
There was a problem hiding this comment.
If there are two and we don't specify one, it'll show the intent picker which is a bad UX. If there are 0, it would have failed at the beginning of the method.
Description: Allows SDK configuration to specify the desired application(s) to launch.
Related issue(s): #130 and #144