New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prioritizing SSO Apps #145

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@thepoofy
Contributor

thepoofy commented Oct 9, 2018

Description: Allows SDK configuration to specify the desired application(s) to launch.

Related issue(s): #130 and #144

@thepoofy thepoofy requested review from tyvsmith and jck2 Oct 9, 2018

Show outdated Hide outdated core-android/src/main/java/com/uber/sdk/android/core/auth/SsoDeeplink.java Outdated
if(!validatedPackages.isEmpty()) {
if (!validatedPackages.isEmpty()) {
intent.setPackage(validatedPackages.get(0).packageName);
}
activity.startActivityForResult(intent, requestCode);

This comment has been minimized.

@jck2

jck2 Oct 9, 2018

Contributor

I know this was here before, do we still want this behavior? My intuition says that we should not be executing the intent if we didn't manage to validate that they have the expected app versions installed

@tyvsmith any thoughts on this?

@jck2

jck2 Oct 9, 2018

Contributor

I know this was here before, do we still want this behavior? My intuition says that we should not be executing the intent if we didn't manage to validate that they have the expected app versions installed

@tyvsmith any thoughts on this?

@jck2

jck2 approved these changes Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment