Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scopes to mapping (Fixes #86) #87

Closed
wants to merge 1 commit into from

Conversation

kjanoudi
Copy link

@kjanoudi kjanoudi commented Aug 22, 2016

This PR adds the missing scopes reported by #86

@jbrophy17
Copy link
Contributor

Hi @kjanoudi thanks for the PR! A few things before I can merge this:

  • Please sign the Uber CLA
  • Could you open this PR agains the 0.5.x-dev branch instead?
  • Could we add a few tests to ensure that this works as expected (and to prevent it happening again?)

@kjanoudi
Copy link
Author

@jbrophy17 Hey. I signed the CLA, but for the next two weeks I actually don't have access to xcode to validate any tests. I'll get to it when I'm back in action though

@edjiang
Copy link
Contributor

edjiang commented Jul 11, 2017

Looks like this was fixed in f752b8d, so closing.

Thanks for your contribution, @kjanoudi! :)

@edjiang edjiang closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants