Skip to content

Commit

Permalink
Improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
dansimau committed Feb 2, 2016
1 parent 57ef514 commit 3317b3f
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ringpop.go
Expand Up @@ -189,10 +189,11 @@ func (rp *Ringpop) identity() (string, error) {
// TChannel object on the Ringpop instance.
func (rp *Ringpop) channelIdentityResolver() (string, error) {
peerInfo := rp.channel.PeerInfo()
// Check that TChannel is listening. By default, TChannel listens on an
// ephemeral host/port. The real port is then assigned by the OS when
// ListenAndServe is called. If the hostport is 0.0.0.0:0, it means
// TChannel is not yet listening and the hostport cannot be resolved.
// Check that TChannel is listening on a real hostport. By default,
// TChannel listens on an ephemeral host/port. The real port is then
// assigned by the OS when ListenAndServe is called. If the hostport is
// ephemeral, it means TChannel is not yet listening and the hostport
// cannot be resolved.
if peerInfo.IsEphemeralHostPort() {
return "", ErrEphemeralIdentity
}
Expand Down

0 comments on commit 3317b3f

Please sign in to comment.