Feedback cleanup.

logging/facility.go

@@ -66,7 +66,7 @@ func (f *Facility) SetLevels(levels map[string]Level) error {
 // SetLevel sets the minimum severity level for a named logger. All messages
 // produced by a named logger with a severity lower than the one set here are
 // silenced.
-// In most of logger implementations, both Fatal and Panic stop the execution.
+// In most logger implementations, both Fatal and Panic stop the execution.
 // This means that those levels only produce a single, and often important,
 // message. Because of that, it's an error to pass a level above Fatal to this
 // method.

logging/level.go

@@ -43,7 +43,9 @@ const (
 	// Debug log level
 	Debug
 
-	maxLevel = int(^uint8(0))
+	// maxLevel is the maximum valid log level.
+	// This is used internally for boundary check.
+	maxLevel = int(255)
 )
 
 // String converts a log level to its string representation.
@@ -84,7 +86,7 @@ func Parse(lvl string) (Level, error) {
 
 	level, err := strconv.Atoi(lvl)
 	if level > maxLevel {
-		err = fmt.Errorf("Invalid level value: %s", lvl)
+		err = fmt.Errorf("invalid level value: %s", lvl)
 	}
 	return Level(level), err
 }