Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sort of) rollback to Xcode 10.1 #20

Merged
merged 1 commit into from Sep 4, 2019
Merged

(Sort of) rollback to Xcode 10.1 #20

merged 1 commit into from Sep 4, 2019

Conversation

rudro
Copy link
Collaborator

@rudro rudro commented Sep 4, 2019

  • We need Xcode 10.1 to create binaries with the swift libs embedded (CI machines have some 10.14.3 ones)
  • SPM is using the master brach of llbuild which is now already on SPM 5.0 spec and is breaking our builds

- We need Xcode 10.1 to create binaries with the swift libs embedded (CI machines have some 10.14.3 ones)
- SPM is using the master brach of llbuild which is now already on SPM 5.0 spec and is breaking our builds
@rudro rudro requested a review from elsh September 4, 2019 21:26
@@ -9,14 +9,14 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/jpsim/SourceKitten.git", from: "0.23.1"),
.package(url: "https://github.com/apple/swift-package-manager.git", .branch("master")),
.package(url: "https://github.com/apple/swift-package-manager.git", .exact("0.3.0")),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: can't have 0.4.0, so need exact. 0.4.0 already uses llbuild master.

@rudro rudro merged commit d8156b9 into master Sep 4, 2019
@rudro rudro deleted the rudro_xcode101 branch September 4, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants