Address code review comments

uber · Nov 15, 2016 · 94acfc8 · 94acfc8
1 parent 5c12f50
commit 94acfc8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/benchmark/real_relay.go b/benchmark/real_relay.go
@@ -36,7 +36,7 @@ type fixedHosts struct {
 	pickI atomic.Int32
 }
 
-func (fh *fixedHosts) Get(cf relay.CallFrame, conn relay.Conn) (string, error) {
+func (fh *fixedHosts) Get(cf relay.CallFrame, _ relay.Conn) (string, error) {
 	peers := fh.hosts[string(cf.Service())]
 	if len(peers) == 0 {
 		return "", errors.New("no peers")

diff --git a/connection.go b/connection.go
@@ -309,7 +309,7 @@ func (ch *Channel) newConnection(conn net.Conn, outboundHP string, initialState
 	c.inbound.onAdded = c.onExchangeAdded
 	c.outbound.onAdded = c.onExchangeAdded
 
-	if ch.relayHost != nil {
+	if ch.RelayHost() != nil {
 		c.relay = NewRelayer(ch, c)
 	}
 

diff --git a/relay/noop.go b/relay/noop.go