Skip to content

Commit

Permalink
Comment out unreachable TODO code
Browse files Browse the repository at this point in the history
  • Loading branch information
Akshay Shah committed Mar 3, 2016
1 parent 388cc1c commit faba39c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Expand Up @@ -98,9 +98,9 @@ lint:
@echo "Running golint"
-golint ./... | $(FILTER) | tee lint.log
@echo "Running go vet"
-go tool vet $(PKGS) 2>&1 | tee -a lint.log
-go tool vet $(PKGS) 2>&1 | grep -v Godeps | tee -a lint.log
@echo "Checking gofmt"
-[ $(GO_VERSION) != "go1.5" ] || gofmt -d . | tee -a lint.log
-[ $(GO_VERSION) != "go1.5" ] || gofmt -d `go list -f {{.Dir}} ./...` | tee -a lint.log
@[ ! -s lint.log ]

thrift_example: thrift_gen
Expand Down
4 changes: 4 additions & 0 deletions frame_test.go
Expand Up @@ -140,10 +140,14 @@ func TestServiceCallReq(t *testing.T) {
// reqResWriter instead of callReq. We should instead handle that in
// callReq, which will allow tests to be sane.
return
/* go vet doesn't like unreachable code...
frame := NewFrame(MaxFramePayloadSize)
err := frame.write(&callReq{Service: "udr"})
require.NoError(t, err, "Error writing message to frame.")
assert.Equal(t, "udr", frame.Service(), "Failed to read service name from frame.")
*/
}

func TestServiceCallReqTerrible(t *testing.T) {
Expand Down

0 comments on commit faba39c

Please sign in to comment.