Publicize channel root peers #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kriskowal
force-pushed
the
publicize-root-peers
branch
from
7ce497c
to
10aff65
Compare
prashantv
approved these changes
Jan 20, 2017
|
This looks like a squash-and-merge repository. c/d? |
kriskowal
force-pushed
the
publicize-root-peers
branch
from
10aff65
to
16ed3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reveals the root peer list on the channel’s public interface. This allows a library, say YARPC, to provide alternate peer list implementations and manage the lifecycle of retained peers without affecting unrelated TChannel proper peer lists.
Test coverage existed for RootPeers as the method was previously exposed as public but only for the purpose of tests. Clever!