feedback

setup.py

@@ -18,7 +18,7 @@
         'crcmod',
         'tornado>=4.0,<5.0',
         'toro>=0.8,<0.9',
-        'thriftrw>=0.3.3,<0.4.0',
+        'thriftrw>=0.3.3,<0.4',
         'threadloop>=0.5,<0.6',
         'futures',
     ],

tchannel/testing/vcr/cassette.py

@@ -68,16 +68,6 @@ class Interaction(namedtuple('Interaction', 'request response')):
     """An interaction is a request-response pair."""
 
     def to_primitive(self):
-        # import ipdb; ipdb.set_trace()
-        # from thriftrw.protocol import BinaryProtocol
-        # p = BinaryProtocol()
-
-        if hasattr(self.request, 'to_primitive'):
-            return {
-                'request': self.request.to_primitive(),
-                'response': self.response.to_primitive(),
-            }
-
         return {
             'request': primitive(self.request, TType.STRUCT),
             'response': primitive(self.response, TType.STRUCT),