vcr shouldn't match on hostport

uber · Sep 18, 2015 · d76e35c · d76e35c
1 parent 6c881e2
commit d76e35c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -4,7 +4,7 @@ Changes by Version
 0.17.2 (unreleased)
 -------------------
 
-- Nothing changed yet.
+- VCR no longer matches on hostport to better support ephemeral ports.
 
 
 0.17.1 (2015-09-17)

diff --git a/tchannel/testing/vcr/cassette.py b/tchannel/testing/vcr/cassette.py
@@ -81,7 +81,7 @@ def matcher(left, right):
 # By default, two requests match if their service name, hostport, endpoint,
 # headers, body, and arg scheme match.
 DEFAULT_MATCHERS = (
-    'serviceName', 'hostPort', 'endpoint', 'headers', 'body', 'argScheme',
+    'serviceName', 'endpoint', 'headers', 'body', 'argScheme',
 )
 # TODO: protocol headers?