TODO

uber · Jul 11, 2015 · a2eb211 · a2eb211
1 parent b4546a5
commit a2eb211
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/node/connection_base.js b/node/connection_base.js
@@ -94,7 +94,7 @@ function connBaseRequest(options) {
 
 TChannelConnectionBase.prototype.handleCallRequest = function handleCallRequest(req) {
     var self = this;
-    
+
     self.ops.addInReq(req);
 
     req.remoteAddr = self.remoteName;

diff --git a/node/relay_handler.js b/node/relay_handler.js
@@ -126,6 +126,7 @@ function LazyRelayInReq(conn, peer, reqFrame) {
 
 LazyRelayInReq.prototype.extendLogInfo = function extendLogInfo(info) {
     var self = this;
+    // TODO: y u no request id? tracing id?
     info.outRemoteAddr = self.outreq && self.outreq.remoteAddr;
     info.inRemoteAddr = self.remoteAddr;
 
@@ -480,6 +481,7 @@ RelayRequest.prototype.onError = function onError(err) {
 
 RelayRequest.prototype.extendLogInfo = function extendLogInfo(info) {
     var self = this;
+    // TODO: y u no request id? tracing id?
     info.outRemoteAddr = self.outreq && self.outreq.remoteAddr;
     info.inRemoteAddr = self.inreq.remoteAddr;
     info.serviceName = self.inreq.serviceName;

diff --git a/node/v2/handler.js b/node/v2/handler.js
@@ -224,6 +224,7 @@ TChannelV2Handler.prototype.handleCallRequest = function handleCallRequest(reqFr
 
     var req = self.buildInRequest(reqFrame);
 
+    // TODO: revive this over lazy call rw
     if (self.incomingRequestInvalid(reqFrame, req)) {
         return null;
     }