Skip to content

Commit

Permalink
Schema change remove "position" as required field for images (#458)
Browse files Browse the repository at this point in the history
  • Loading branch information
twojtasz committed May 24, 2019
1 parent ed0ba18 commit 51e6c9f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions modules/schema/examples/primitives/image/required.json
@@ -0,0 +1,5 @@
{
"data": "/9j/2wBDAAMCAgICAgMCAgIDAwMDBAYEBAQEBAgGBgUGCQgKCgkICQkKDA8MCgsOCwkJDRENDg8QEBEQCgwSExIQEw8QEBD/yQALCAABAAEBAREA/8wABgAQEAX/2gAIAQEAAD8A0s8g/9k=",
"width_px": 1280,
"height_px": 720
}
2 changes: 1 addition & 1 deletion modules/schema/schema/primitives/image.schema.json
Expand Up @@ -27,6 +27,6 @@
"minValue": 0
}
},
"required": [ "position", "data", "width_px", "height_px" ],
"required": [ "data", "width_px", "height_px" ],
"additionalProperties": false
}
1 change: 1 addition & 0 deletions test/modules/schema/examples.json
Expand Up @@ -62,6 +62,7 @@
"primitives/point/per_point_colors.json",
"primitives/point/simple.json",
"primitives/image/complex.json",
"primitives/image/required.json",
"primitives/image/simple.json",
"primitives/circle/complex.json",
"primitives/circle/simple.json",
Expand Down

0 comments on commit 51e6c9f

Please sign in to comment.