add accidentally removed comment back

uber · Nov 8, 2019 · 5a7e260 · 5a7e260
1 parent c12cfcf
commit 5a7e260
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/codegen/template_bundle/template_files.go b/codegen/template_bundle/template_files.go
diff --git a/codegen/templates/http_client.tmpl b/codegen/templates/http_client.tmpl
@@ -334,6 +334,8 @@ func (c *{{$clientName}}) {{$methodName}}(
 		{{range $code, $exceptions := .ExceptionsByStatusCode -}}
 		case {{$code}}:
 			{{- if or (eq $code 204) (eq $code 304) -}}
+				{{/* If multiple exceptions have 204/304 status code mapped, we aren't able to distinguish between them */}}
+				{{/* so we'll just return the first exception that has 204/304 status code set. */}}
 				{{$val := index $exceptions 0}}
 				return respHeaders, &{{$val.Type}}{}
 			{{else}}
@@ -384,6 +386,8 @@ func (c *{{$clientName}}) {{$methodName}}(
 		{{range $code, $exceptions := .ExceptionsByStatusCode -}}
 		case {{$code}}:
 			{{- if or (eq $code 204) (eq $code 304) -}}
+				{{/* If multiple exceptions have 204/304 status code mapped, we aren't able to distinguish between them */}}
+				{{/* so we'll just return the first exception that has 204/304 status code set. */}}
 				{{$val := index $exceptions 0}}
 				return defaultRes, respHeaders, &{{$val.Type}}{}
 			{{else}}

diff --git a/examples/example-gateway/build/clients/corge-http/corge-http.go b/examples/example-gateway/build/clients/corge-http/corge-http.go