Skip to content

Commit

Permalink
Merge c4e2dcc into 97f20b6
Browse files Browse the repository at this point in the history
  • Loading branch information
tejaswiagarwal committed Mar 28, 2020
2 parents 97f20b6 + c4e2dcc commit 685f8be
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion runtime/constants.go
Expand Up @@ -50,7 +50,7 @@ const (
// clientHTTPUnmarshalError is the metric for tracking errors due to unmarshalling json responses
clientHTTPUnmarshalError = "client.http-unmarshal-error"
// clientTchannelReadError is the metric for tracking errors in reading tchannel response
clientTchannelReadError = "client.tchannel-read-error"
clientTchannelUnmarshalError = "client.tchannel-unmarshal-error"
)

var knownMetrics = []string{
Expand Down
2 changes: 1 addition & 1 deletion runtime/tchannel_outbound_call.go
Expand Up @@ -230,7 +230,7 @@ func (c *tchannelOutboundCall) readResBody(ctx context.Context, response *tchann
}
if err := ReadStruct(treader, resp); err != nil {
_ = treader.Close()
c.metrics.IncCounter(ctx, clientTchannelReadError, 1)
c.metrics.IncCounter(ctx, clientTchannelUnmarshalError, 1)
return errors.Wrapf(
err, "Could not read outbound %s.%s (%s %s) response",
c.client.ClientID, c.methodName, c.client.serviceName, c.serviceMethod,
Expand Down

0 comments on commit 685f8be

Please sign in to comment.