comment

uber · Mar 14, 2018 · 6a832e9 · 6a832e9
1 parent ff27b7e
commit 6a832e9
Show file tree

Hide file tree

Showing 37 changed files with 26 additions and 37 deletions.
diff --git a/codegen/template_bundle/template_files.go b/codegen/template_bundle/template_files.go
diff --git a/codegen/templates/endpoint.tmpl b/codegen/templates/endpoint.tmpl
@@ -131,6 +131,7 @@ func (h *{{$handlerName}}) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 	{{if ne .RequestType ""}}
+	// TODO: potential perf issue, use zap.Object lazy serialization
 	zfields = append(zfields, zap.String("body", requestBody.String()))
 	{{- end -}}
 
@@ -144,7 +145,6 @@ func (h *{{$handlerName}}) HandleRequest(
 		zfields = append(zfields, zap.String("{{$k}}", headerValue))
 	}
 	{{- end}}
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := {{$workflow}}{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argnotstruct.gogen b/codegen/test_data/endpoints/bar_bar_method_argnotstruct.gogen
@@ -81,8 +81,8 @@ func (h *BarArgNotStructHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgNotStructEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithheaders.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithheaders.gogen
@@ -90,14 +90,14 @@ func (h *BarArgWithHeadersHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
+	// TODO: potential perf issue, use zap.Object lazy serialization
 	zfields = append(zfields, zap.String("body", requestBody.String()))
 	var headerOk bool
 	var headerValue string
 	headerValue, headerOk = req.Header.Get("X-Uuid")
 	if headerOk {
 		zfields = append(zfields, zap.String("X-Uuid", headerValue))
 	}
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithHeadersEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithmanyqueryparams.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithmanyqueryparams.gogen
@@ -212,8 +212,8 @@ func (h *BarArgWithManyQueryParamsHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithManyQueryParamsEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithnestedqueryparams.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithnestedqueryparams.gogen
@@ -156,8 +156,8 @@ func (h *BarArgWithNestedQueryParamsHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithNestedQueryParamsEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithparams.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithparams.gogen
@@ -87,8 +87,8 @@ func (h *BarArgWithParamsHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithParamsEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithqueryheader.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithqueryheader.gogen
@@ -84,8 +84,8 @@ func (h *BarArgWithQueryHeaderHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithQueryHeaderEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_argwithqueryparams.gogen b/codegen/test_data/endpoints/bar_bar_method_argwithqueryparams.gogen
@@ -98,6 +98,7 @@ func (h *BarArgWithQueryParamsHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
+	// TODO: potential perf issue, use zap.Object lazy serialization
 	zfields = append(zfields, zap.String("body", requestBody.String()))
 	var headerOk bool
 	var headerValue string
@@ -109,7 +110,6 @@ func (h *BarArgWithQueryParamsHandler) HandleRequest(
 	if headerOk {
 		zfields = append(zfields, zap.String("X-Uuid", headerValue))
 	}
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarArgWithQueryParamsEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_helloworld.gogen b/codegen/test_data/endpoints/bar_bar_method_helloworld.gogen
@@ -79,7 +79,6 @@ func (h *BarHelloWorldHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarHelloWorldEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_missingarg.gogen b/codegen/test_data/endpoints/bar_bar_method_missingarg.gogen
@@ -77,7 +77,6 @@ func (h *BarMissingArgHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarMissingArgEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_norequest.gogen b/codegen/test_data/endpoints/bar_bar_method_norequest.gogen
@@ -77,7 +77,6 @@ func (h *BarNoRequestHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarNoRequestEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_normal.gogen b/codegen/test_data/endpoints/bar_bar_method_normal.gogen
@@ -90,8 +90,8 @@ func (h *BarNormalHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
-	zfields = append(zfields, zap.String("body", requestBody.String()))
 	// TODO: potential perf issue, use zap.Object lazy serialization
+	zfields = append(zfields, zap.String("body", requestBody.String()))
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarNormalEndpoint{

diff --git a/codegen/test_data/endpoints/bar_bar_method_toomanyargs.gogen b/codegen/test_data/endpoints/bar_bar_method_toomanyargs.gogen
@@ -87,6 +87,7 @@ func (h *BarTooManyArgsHandler) HandleRequest(
 		zap.String("endpoint", h.endpoint.EndpointName),
 	}
 
+	// TODO: potential perf issue, use zap.Object lazy serialization
 	zfields = append(zfields, zap.String("body", requestBody.String()))
 	var headerOk bool
 	var headerValue string
@@ -98,7 +99,6 @@ func (h *BarTooManyArgsHandler) HandleRequest(
 	if headerOk {
 		zfields = append(zfields, zap.String("X-Uuid", headerValue))
 	}
-	// TODO: potential perf issue, use zap.Object lazy serialization
 	req.Logger.Debug("Endpoint request to downstream", zfields...)
 
 	workflow := BarTooManyArgsEndpoint{

diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argnotstruct.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argnotstruct.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithheaders.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithheaders.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithmanyqueryparams.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithmanyqueryparams.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithnestedqueryparams.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithnestedqueryparams.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithparams.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithparams.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithqueryheader.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithqueryheader.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithqueryparams.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_argwithqueryparams.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_helloworld.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_helloworld.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_missingarg.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_missingarg.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_norequest.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_norequest.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_normal.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_normal.go
diff --git a/examples/example-gateway/build/endpoints/bar/bar_bar_method_toomanyargs.go b/examples/example-gateway/build/endpoints/bar/bar_bar_method_toomanyargs.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_call.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_call.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_compare.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_compare.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_ping.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_ping.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_sillynoop.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_sillynoop.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_trans.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_trans.go
diff --git a/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_transheaders.go b/examples/example-gateway/build/endpoints/baz/baz_simpleservice_method_transheaders.go
diff --git a/examples/example-gateway/build/endpoints/contacts/contacts_contacts_method_savecontacts.go b/examples/example-gateway/build/endpoints/contacts/contacts_contacts_method_savecontacts.go
diff --git a/...es/example-gateway/build/endpoints/googlenow/googlenow_googlenow_method_addcredentials.go b/...es/example-gateway/build/endpoints/googlenow/googlenow_googlenow_method_addcredentials.go
diff --git a/.../example-gateway/build/endpoints/googlenow/googlenow_googlenow_method_checkcredentials.go b/.../example-gateway/build/endpoints/googlenow/googlenow_googlenow_method_checkcredentials.go
diff --git a/examples/example-gateway/build/endpoints/multi/multi_serviceafront_method_hello.go b/examples/example-gateway/build/endpoints/multi/multi_serviceafront_method_hello.go