Skip to content

Commit

Permalink
Merge d062dcb into 0ccf800
Browse files Browse the repository at this point in the history
  • Loading branch information
abhishekparwal committed Sep 24, 2019
2 parents 0ccf800 + d062dcb commit a312a3e
Show file tree
Hide file tree
Showing 60 changed files with 2,013 additions and 715 deletions.
10 changes: 1 addition & 9 deletions codegen/module_system.go
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,6 @@ func (g *TChannelClientGenerator) Generate(
ClientID: clientSpec.ClientID,
ExposedMethods: exposedMethods,
SidecarRouter: clientSpec.SidecarRouter,
StagingReqHeader: g.packageHelper.StagingReqHeader(),
DeputyReqHeader: g.packageHelper.DeputyReqHeader(),
}

Expand Down Expand Up @@ -1147,13 +1146,7 @@ func (g *EndpointGenerator) generateEndpointFile(
if reqHeaders == nil {
reqHeaders = make(map[string]*TypedHeader)
}
shk := textproto.CanonicalMIMEHeaderKey(g.packageHelper.StagingReqHeader())
reqHeaders[shk] = &TypedHeader{
Name: shk,
TransformTo: shk,
Field: &compile.FieldSpec{Required: false},
}
shk = textproto.CanonicalMIMEHeaderKey(g.packageHelper.DeputyReqHeader())
shk := textproto.CanonicalMIMEHeaderKey(g.packageHelper.DeputyReqHeader())
reqHeaders[shk] = &TypedHeader{
Name: shk,
TransformTo: shk,
Expand Down Expand Up @@ -1539,7 +1532,6 @@ type ClientMeta struct {
ExposedMethods map[string]string
SidecarRouter string
Fixture *Fixture
StagingReqHeader string
DeputyReqHeader string
GenPkg string
}
Expand Down
16 changes: 0 additions & 16 deletions codegen/package.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ type PackageHelper struct {
middlewareSpecs map[string]*MiddlewareSpec
// The default middlewares for all endpoints
defaultMiddlewareSpecs map[string]*MiddlewareSpec
// Use staging client when this header is set as "true"
stagingReqHeader string
// Use deputy client when this header is set
deputyReqHeader string
// traceKey is the key for unique trace id that identifies request / response pair
Expand Down Expand Up @@ -145,13 +143,6 @@ func (p *PackageHelperOptions) copyrightHeader() string {
return ""
}

func (p *PackageHelperOptions) stagingReqHeader() string {
if p.StagingReqHeader != "" {
return p.StagingReqHeader
}
return "X-Zanzibar-Use-Staging"
}

func (p *PackageHelperOptions) deputyReqHeader() string {
if p.DeputyReqHeader != "" {
return p.DeputyReqHeader
Expand Down Expand Up @@ -210,7 +201,6 @@ func NewPackageHelper(
middlewareSpecs: middlewareSpecs,
defaultMiddlewareSpecs: defaultMiddlewareSpecs,
annotationPrefix: options.annotationPrefix(),
stagingReqHeader: options.stagingReqHeader(),
deputyReqHeader: options.deputyReqHeader(),
traceKey: options.traceKey(),
moduleSearchPaths: options.ModuleSearchPaths,
Expand Down Expand Up @@ -340,12 +330,6 @@ func (p PackageHelper) TypeFullName(typeSpec compile.TypeSpec) (string, error) {
return GoType(p, typeSpec)
}

// StagingReqHeader returns the header name that will be checked to determine
// if a request should go to the staging downstream client
func (p PackageHelper) StagingReqHeader() string {
return p.stagingReqHeader
}

// DeputyReqHeader returns the header name that will be checked to determine
// if a request should go to the deputy downstream client
func (p PackageHelper) DeputyReqHeader() string {
Expand Down

0 comments on commit a312a3e

Please sign in to comment.