Skip to content

Commit

Permalink
Merge branch 'master' into fixlogapm2
Browse files Browse the repository at this point in the history
  • Loading branch information
amolmejari2 committed Jul 12, 2023
2 parents 82f909a + f35b54e commit b907bb6
Show file tree
Hide file tree
Showing 11 changed files with 70 additions and 40 deletions.
23 changes: 14 additions & 9 deletions codegen/template_bundle/template_files.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 8 additions & 5 deletions codegen/templates/main.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ type Result struct {
Gateway *zanzibar.Gateway
// Provider is an abstraction over the Zanzibar config store
Provider uberconfig.Provider `name:"zanzibarConfig"`
// Deps is a reference to the dependency tree inside zanzibar gateway
Deps *service.DependenciesTree
}

func main() {
Expand All @@ -74,7 +76,7 @@ func run(gateway *zanzibar.Gateway) {
// or modify Result. Most users should use Module instead.
func New(p Params) (Result, error) {
readFlags()
gateway, err := createGateway()
gateway, deps, err := createGateway()
if err != nil {
return Result{}, errors.Wrap(err, "failed to create gateway server")
}
Expand Down Expand Up @@ -113,16 +115,17 @@ func New(p Params) (Result, error) {
return Result{
Gateway: gateway,
Provider: provider,
Deps: deps,
}, nil
}

func createGateway() (*zanzibar.Gateway, error) {
func createGateway() (*zanzibar.Gateway, *service.DependenciesTree, error) {
cfg := getConfig()
gateway, _, err := service.CreateGateway(cfg, app.AppOptions)
gateway, deps, err := service.CreateGateway(cfg, app.AppOptions)
if err != nil {
return nil, err
return nil, nil, err
}
return gateway, nil
return gateway, deps.(*service.DependenciesTree), nil
}

func getConfig() *zanzibar.StaticConfig {
Expand Down
6 changes: 4 additions & 2 deletions codegen/templates/main_test.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ import (
"syscall"
"testing"

"github.com/stretchr/testify/assert"
zanzibar "github.com/uber/zanzibar/runtime"
"go.uber.org/zap"
"go.uber.org/zap/zapcore"
zanzibar "github.com/uber/zanzibar/runtime"

module "{{$instance.PackageInfo.ModulePackagePath}}"
)
Expand Down Expand Up @@ -57,14 +58,15 @@ func TestStartGateway(t *testing.T) {
),
)

gateway, err := createGateway()
gateway, deps, err := createGateway()
if err != nil {
testLogger.Error(
"Failed to CreateGateway in TestStartGateway()",
zap.Error(err),
)
return
}
assert.NotNil(t, deps)

cachedServer = gateway
err = gateway.Bootstrap()
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b907bb6

Please sign in to comment.