You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, running make test-update over-writes the examples/example-gateway/config/production.json config file with values from backend/repository/data/client/baz_client_update.json.
Please make examples/example-gateway/config/production.json the one source of truth for config settings.
The text was updated successfully, but these errors were encountered:
I think this might be the intended behavior? To the gateway UI, config/production.json is the derived/aggregated data from the configs of each client. @zhenghuiwang Can you clarify?
The interesting thing here is zanzibar and the UI backend has different favors on some of the client configs, i.e., zanzibar thinks the ip/port info should be in config/production.json while UI backend gets it from client config.
To the gateway UI, config/production.json is the derived/aggregated data from the configs of each client. @zhenghuiwang Can you clarify?
Yes, that is correct.
The issue here is the conflict about how to use example-gateway for unit tests. On the one hand, it is used as test fixtures from the very beginning of the project. On the other hand, after introducing the UI backend, it is also the expected configuration after backend modification.
That's why Ravi is confused about why handwritten fields get override by make test-update. We can extract all UI backend request from production.json and write it back to make production.json the source of truth, but I think it's not worth the effort and may not result in good tests.
Currently, running
make test-update
over-writes theexamples/example-gateway/config/production.json
config file with values frombackend/repository/data/client/baz_client_update.json
.Please make
examples/example-gateway/config/production.json
the one source of truth for config settings.The text was updated successfully, but these errors were encountered: