Set full type for request and respone #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raynos
reviewed
May 22, 2017
| @@ -198,12 +198,15 @@ func (ms *MethodSpec) setRequestType(curThriftFile string, funcSpec *compile.Fun | |||
| ms.RequestType, err = packageHelper.TypeFullName( | |||
| curThriftFile, funcSpec.ArgsSpec[0].Type, | |||
| ) | |||
| if err == nil && isStructType(funcSpec.ArgsSpec[0].Type) { | |||
There was a problem hiding this comment.
can we add TODO here to check typedef semantics.
There was a problem hiding this comment.
typedef should be covered since the type assertion is against the RootTypeSpec of given spec. https://github.com/uber/zanzibar/blob/master/codegen/method.go#L217
| @@ -225,6 +228,9 @@ func (ms *MethodSpec) setResponseType(curThriftFile string, respSpec *compile.Re | |||
| return nil | |||
| } | |||
| typeName, err := packageHelper.TypeFullName(curThriftFile, respSpec.ReturnType) | |||
| if isStructType(respSpec.ReturnType) { | |||
There was a problem hiding this comment.
can we add a TODO here to check typedef semantics.
| func convertTo{{title .Name}}ClientRequest(in *{{.RequestType}}) *{{$clientReqType}} { | ||
| out := &{{$clientReqType}}{} | ||
| func convertTo{{title .Name}}ClientRequest(in {{.RequestType}}) {{$clientReqType}} { | ||
| out := &{{unref $clientReqType}}{} |
There was a problem hiding this comment.
&string{} will probably break here ?
We need some kind of "is primitive" check and not generate converters for non-struct types.
There was a problem hiding this comment.
That's good point.
Raynos
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we assume all request and response types are struct pointer type, and prefix
*in our templates. This assumption is not always valid.This PR sets the full request and response type without assuming it is a struct pointer type.