resolve module dependencies #106
Conversation
codegen/module.go
Outdated
| @@ -269,6 +269,54 @@ func (system *ModuleSystem) ResolveModules( | |||
| append(resolvedDependencies, dependencyInstance) | |||
| } | |||
| } | |||
|
|
|||
| // Resolve the class dependencies | |||
| for _, classInstance := range classInstances { | |||
There was a problem hiding this comment.
looks like merge-conflict. we have this loop twice
There was a problem hiding this comment.
Yes we have this loop twice because the current class instances need to be fully resolved before you can resolve the dependencies (because clients can have peer dependencies, for example). So basically you have to create all possible dependency ModuleInstance objects before you can populate the ResolvedDependencies. I don't think this is incorrect.
There was a problem hiding this comment.
Can you leave a comment, the loops looked identical at a glance.
| @@ -169,3 +256,185 @@ func getTestDirName() string { | |||
| // If dirname is not absolute then its a package name... | |||
| return filepath.Join(os.Getenv("GOPATH"), "src", dirname) | |||
| } | |||
|
|
|||
| func compareInstances( | |||
There was a problem hiding this comment.
this method can be replaced with assert.Equal(t, actual, expected)
There was a problem hiding this comment.
It's not fully equal because there is binary content, I'm asserting a subset
codegen/module.go
Outdated
|
|
||
| if !ok { | ||
| return nil, errors.Errorf( | ||
| "Invalid class name \"%q\" in dependencies for %s %s", |
There was a problem hiding this comment.
I am guessing "Invalid class name %q in dependencies for %q %q" is what you want here?
codegen/module.go
Outdated
|
|
||
| if dependencyInstance == nil { | ||
| return nil, errors.Errorf( | ||
| "Unknown %q class depdendency \"%q\""+ |
There was a problem hiding this comment.
Same as above, redundant quotes for %q
There was a problem hiding this comment.
I'm not entirely sure that %q is right at all, but I will try to make it consistent at least.
Populates the resolved dependencies for each module instance in the module system. This will be used by the dependency struct generation code.