add instrumentation to http client dial #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srivastavankit
commented
May 23, 2017
srivastavankit
commented
- first attempt at adding instrumentation only for http dial
Raynos
reviewed
May 23, 2017
| BaseURL string | ||
| } | ||
|
|
||
| // NewHTTPClient will allocate a http client. | ||
| func NewHTTPClient( | ||
| gateway *Gateway, baseURL string, | ||
| ) *HTTPClient { | ||
| scope := gateway.MetricScope.SubScope("") // TODO: get http client name | ||
| timer := scope.Timer("dial") |
There was a problem hiding this comment.
nitpick: a more specific metric name like http-client.dial might be nicer.
| func getInstrumentedDial(timer tally.Timer, successCtr, errorCtr tally.Counter) func(string, string) (net.Conn, error) { | ||
| return func(n, a string) (conn net.Conn, err error) { | ||
| stat := instrument(timer, successCtr, errorCtr) | ||
| defer func() { |
There was a problem hiding this comment.
nitpick: i find defers hard to read because of unwinding.
stat := instrument(timer, successCtr, errorCtr);
conn, err := net.Dial(n, a)
stat(err)
return conn, err
is easier to read.
|
|
||
| // HTTPClient defines a http client. | ||
| type HTTPClient struct { | ||
| gateway *Gateway | ||
|
|
||
| Client *http.Client | ||
| Logger *zap.Logger | ||
| Scope *tally.Scope | ||
| BaseURL string | ||
| } | ||
|
|
||
| // NewHTTPClient will allocate a http client. | ||
| func NewHTTPClient( | ||
| gateway *Gateway, baseURL string, |
There was a problem hiding this comment.
we can add an extra argument here for httpClientName.
Then update the template ( https://github.com/uber/zanzibar/blob/master/codegen/templates/http_client.tmpl#L37 ), should be "{{.Name}}"
|
PR is stale. Will close for now. Feel free to re-open if still wanted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.