Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: update lua scripts to send working requests #110

Merged
merged 1 commit into from
May 24, 2017

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented May 24, 2017

The benchmarks lua's were stale compared to the validation
that we do.

When we run the benchmarks they "work", aka wrk is able
to send requests, however the benchmarks we run do
not return 2xx and wrk mentions this but wrk is happy
about any response.

r: @uber/zanzibar-team

@coveralls
Copy link

coveralls commented May 24, 2017

Coverage Status

Coverage remained the same at 73.784% when pulling be24dcc on fix-benchmarks into f7255d5 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants