generate client from module instance #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting that the default name for Googlenow client is now defined in the module system, and it changes from GoogleNow. We may wish to change the way that this name is computed, but it is standardized via the computed moduleInstance.PackageInfo. Updating how PackageInfo is computed should update all references without breaking. Consistency and single source of truth, can you imagine it. |
Raynos
approved these changes
Jun 2, 2017
Raynos
force-pushed
the
me.generate.instance
branch
from
3258c83
to
f1c7f09
Compare
|
I rebased it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to standardize on using the module instance as the source of truth. I am using the module instance PackageInfo to define the export type, export name and globally unique aliases when importing in generated code.