Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a bunch of tests for http_server_response.go #15

Merged
merged 18 commits into from Mar 27, 2017
Merged

Write a bunch of tests for http_server_response.go #15

merged 18 commits into from Mar 27, 2017

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented Mar 25, 2017

I'm looking into add PeekBody() to HTTPServerResponse.

This is a pre-cursor PR that just ramps up the test coverage
so that we can iterate without breaking existing code & features.

  • Add GetErrorLogs() to BenchGateway
  • Add support for zap.SyncWriter in Gateway
  • Refactor and remove unneeded CopyJSON()
  • Remove unused WriteHeader
  • Write a bunch of tests.
  • Clamp code coverage @ 100% for runtime/*
  • Add nil gaurd to WriteJSON to avoid panics.

r: @uber/zanzibar-team

@Raynos
runtime/gateway: add support for extra log writer
417ee4d
@Raynos
test/lib/bench_gateway: implement GetErrorLogs()
a4a2894
@Raynos
runtime/server_http_response: add nil gaurd
7a2245b
@Raynos
scripts/cover.sh: improve pretty printing
70a7ce9
@Raynos
server_http_response_test: add test for bad status code
52afea7
@Raynos
runtime/server_http_response: add coverage ignore
cea00fe
@Raynos
tests: write tests for backend down
2bcfb5a
@Raynos
example-gateway: update SaveContacts to write json payload
1ebbeed
@Raynos
runtime/ServerResponse remove CopyJSON
42486b0
@Raynos
runtime/ServerResponse: do not use WriteHeader
5061a53
@Raynos
runtime/ServerResponse: add ignore on non-trivial line
8e10ccf
@Raynos
tests: add more runtime ServerResponse cases
a6eecc9
@Raynos
tests: add another test for status code use cases
832a705
@Raynos
runtime/http_server: add coverage ignore for hard cases/
fbdc871
@Raynos
tests: add test for tchannel_server
762b549
@Raynos
scripts/cover.sh: add 100% code coverage check for runtime
1b8ae95
@Raynos
scripts/covers.sh: cleanup test artifact
eccc7ea
@Raynos
Copy link
Contributor Author

Raynos commented Mar 25, 2017

image

@Raynos Raynos merged commit 7644943 into master Mar 27, 2017
@Raynos Raynos deleted the http-server-response-tests branch March 27, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenghuiwang zhenghuiwang zhenghuiwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Raynos @zhenghuiwang