Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest zap@1.1.0 #40

Merged
merged 4 commits into from
Apr 7, 2017
Merged

Upgrade to latest zap@1.1.0 #40

merged 4 commits into from
Apr 7, 2017

Conversation

Raynos
Copy link
Contributor

@Raynos Raynos commented Apr 6, 2017 •
edited
Loading

There are some breaking changes now that zap is 1.0

  • Changed constructor interface
  • Changed from zap.Logger -> *zap.Logger
  • Changed from zap.Object -> zap.Any

r: @uber/zanzibar-team

@coveralls
Copy link

coveralls commented Apr 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.744% when pulling ab9a1e4 on log-fields into 37411f1 on master.

@coveralls
Copy link

coveralls commented Apr 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 71.032% when pulling 2dd19f1 on log-fields into 401280f on master.

ChuntaoLu
ChuntaoLu approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@ChuntaoLu ChuntaoLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we land after my PR lands?

@coveralls
Copy link

coveralls commented Apr 7, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 73.835% when pulling 59d15b2 on log-fields into d8685e9 on master.

@Raynos Raynos merged commit cff50c9 into master Apr 7, 2017
@Raynos Raynos deleted the log-fields branch April 7, 2017 19:44
@CortezFrazierJr CortezFrazierJr mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevededalus stevededalus stevededalus approved these changes

@ChuntaoLu ChuntaoLu ChuntaoLu approved these changes

@zhenghuiwang zhenghuiwang zhenghuiwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Raynos @coveralls @stevededalus @ChuntaoLu @zhenghuiwang