Fix static config inspection #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuntaoLu
requested review from
l-w-2017 and
jacobgreenleaf
and removed request for
l-w-2017
|
hmm, travis is having issues atm https://www.traviscistatus.com/ |
| err := yaml.Unmarshal(bytes, &object) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return object | ||
| return stringizeMapKey(object).(map[string]interface{}) |
There was a problem hiding this comment.
Won't this type assertion fail if you take the []interface{} case in stringizeMapKey? Since it passes tests, does that make the []interface{} case dead code if doesn't occur?
There was a problem hiding this comment.
object is declared of type map[interface{}]interface{}, so the conversion should not fail. The []interface{} case is for when the value is a slice of maps where the keys are also interface{} and need to be stringized.
l-w-2017
reviewed
Oct 23, 2018
| err := yaml.Unmarshal(bytes, &object) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return object | ||
| return stringizeMapKey(object).(map[string]interface{}) |
There was a problem hiding this comment.
nit: stringizeMapKey ---> stringifyMapKey
l-w-2017
approved these changes
Oct 23, 2018
jacobgreenleaf
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the config inspection logging field.
Previously upon starting the server, the logging field errors:
Now: