Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL logging to server_http_request #613

Merged
merged 1 commit into from Jul 25, 2019
Merged

Add URL logging to server_http_request #613

merged 1 commit into from Jul 25, 2019

Conversation

smb158
Copy link
Contributor

@smb158 smb158 commented Jul 25, 2019

When our service gets a request for a URL we dont handle, we only see in the logs that it was handled by our 404handler and not what the URL itself was. This makes debugging hard.

@smb158 smb158 requested a review from ChuntaoLu July 25, 2019 00:35
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.605% when pulling 8474618 on add-url-logging into 8c774c1 on master.

@ChuntaoLu ChuntaoLu merged commit e6898db into master Jul 25, 2019
@ChuntaoLu ChuntaoLu deleted the add-url-logging branch July 25, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuntaoLu ChuntaoLu ChuntaoLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smb158 @CLAassistant @coveralls @ChuntaoLu