yaml parser in PR#626 renders lines as dead code #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initially when we moved from JSON -> YAML, there were some changes needed on how to read Float but those are rendered useless as part of PR# 626. This dead code is causing coverage to drop. Since this code path is not taken, a unit test can't be implemented either. Deleting this deadcode here also helps coverage come back up to 100% for ./runtime/* dir
jacobgreenleaf
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initially when we moved from JSON -> YAML, there were some changes
needed on how to read Float but those are rendered useless as part of
PR# 626.
This dead code is causing coverage to drop. Since this code path is not
taken, a unit test can't be implemented either.
Deleting this deadcode here also helps coverage come back up
to 100% for ./runtime/* dir