Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query-param handling on the client side #655

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

argouber
Copy link
Contributor

@argouber argouber commented Oct 8, 2019

There are scenarios where the annotations are ignored when the client thrift actually specifies it.
Similarly on the endpoint thrift, handling had some bugs

  • Optional query param is the only item present in the struct and has an annotation that does not include the struct field's name. We do not handle this correctly.

There are scenarios where the annotations are ignored when the client thrift actually specifies it.
Similarly on the endpoint thrift, handling had some bugs. This fixes both.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 67.841% when pulling 5e8c7dd on argo/qparam_fixes into f018151 on master.

@argouber argouber merged commit 8772bad into master Oct 9, 2019
@argouber argouber deleted the argo/qparam_fixes branch July 2, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants