Allow only system failures to trigger circuit breaker #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the downstream client call fails due to application errors, we should not count that towards the circuit breaker threshold. The systems are still behaving okay. For tchannel, it is the "system errors" For http downstream, we sorta count 5xx as system failures. This may not always be the case, but is there a better way? For grpc downstream, all exceptions are system errors, so things should be okay.
argouber
commented
Nov 2, 2019
rpatali
reviewed
Nov 5, 2019
rpatali
approved these changes
Nov 5, 2019
abhishekparwal
requested changes
Nov 5, 2019
codegen/templates/http_client.tmpl
Outdated
| err = hystrix.DoC(ctx, "{{$clientID}}", func(ctx context.Context) error { | ||
| res, err = req.Do() | ||
| return err | ||
| res, realErr = req.Do() |
There was a problem hiding this comment.
I would choose variable name as clientErr rather than realErr. real vs unreal it looks like from variable name currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the downstream client call fails due to application errors, we should not count that towards
the circuit breaker threshold. The systems are still behaving okay.
For tchannel, it is the "system errors"
For http downstream, we sorta count 5xx as system failures. This may not always be the case, but is there a better way?
For grpc downstream, all exceptions are system errors, so things should be okay.