Serverless zanzibar #676
Merged
Serverless zanzibar #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without a downstream, to echo the response back and use a new serverless middleware
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
argouber
reviewed
Dec 12, 2019
… without a downstream, to echo the response back and use a new serverless middleware
argouber
reviewed
Dec 16, 2019
argouber
reviewed
Dec 16, 2019
codegen/method.go
Outdated
| *compile.DoubleSpec, | ||
| *compile.StringSpec: | ||
|
|
||
| dummyConverter.append("out", " := in\t\n") |
There was a problem hiding this comment.
isn't this just "out := in\n"
There is no point in having a trailing \t
argouber
reviewed
Dec 16, 2019
argouber
approved these changes
Dec 16, 2019
rpatali
reviewed
Dec 16, 2019
examples/example-gateway/endpoints/serverless/serverless-empty.yaml
Outdated
Show resolved
Hide resolved
examples/example-gateway/endpoints/serverless/serverless-empty.yaml
Outdated
Show resolved
Hide resolved
| @@ -275,6 +279,8 @@ type EndpointSpec struct { | |||
| ClientMethod string `yaml:"clientMethod,omitempty"` | |||
| // The client for this endpoint if httpClient or tchannelClient | |||
| ClientSpec *ClientSpec `yaml:"-"` | |||
| // DummyEndpoint checks if the endpoint is serverless | |||
| IsDummyEndpoint bool `yaml:"-"` | |||
There was a problem hiding this comment.
call it clientless and other places throughout the code.
| @@ -1000,6 +1003,61 @@ func (ms *MethodSpec) setTypeConverters( | |||
| return nil | |||
| } | |||
|
|
|||
| func (ms *MethodSpec) setDummyTypeConverters( | |||
There was a problem hiding this comment.
call it ClientLessConverter
examples/example-gateway/endpoints/serverless/serverless-empty.yaml
Outdated
Show resolved
Hide resolved
|
This is a clientless feature and not a serverless. server has a standard meaning and lets not change it. server is in this case zanzibar. |
|
|
||
| {{with .Method -}} | ||
| // {{$workflowInterface}} defines the interface for {{$serviceMethod}} workflow | ||
| type {{$workflowInterface}} interface { |
There was a problem hiding this comment.
This interface should not be redeclared, it should be common b/w various workflows. program to interface and not to implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature in Zanzibar to have a serverless mode. Endpoints can be created without a downstream, the workflow is short-circuited together to return a response to the caller. A new type convertor flow was added to convert Request to Response type, which is used by the serverless middleware.