update deputy middleware to properly close channel between connections #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change deputy middleware to open a new channel, rather than use a sub-channel and edit the Peers list.
From tchannel code:
Observed that with the subchannel implementation, connections using deputy would work sporadically, especially soon after a service restart, but would start failing later, possibly after the Cerberus CLI session was restarted.
Creating a new channel and closing it is consistent with the more generic middleware supported by Cerberus/Deputy team.
See https://code.uberinternal.com/T4892307 for internal Uber details