Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import in http_client.tmpl #740

Merged
merged 1 commit into from Aug 24, 2020
Merged

Add missing import in http_client.tmpl #740

merged 1 commit into from Aug 24, 2020

Conversation

ChuntaoLu
Copy link
Contributor

This PR fixes the http_client.tmpl that fails to import "github.com/uber/zanzibr/config" in a recent change.

rpatali
rpatali approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@rpatali rpatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.433% when pulling 3744308 on lu.import into 2b42548 on master.

@ChuntaoLu ChuntaoLu merged commit 8acadc4 into master Aug 24, 2020
@ChuntaoLu ChuntaoLu deleted the lu.import branch August 24, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpatali rpatali rpatali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChuntaoLu @coveralls @rpatali