Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved notFoundHandler init after observability tools init #868

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

hbhoyar-uber
Copy link
Contributor

When notFoundHandler was initialised, it used to get logger and scope as nil. Hence, initialising notFoundHandler after all the observability tools are initialised

@coveralls
Copy link

Coverage Status

Coverage: 69.347%. Remained the same when pulling b8faee7 on not_found_handler into 139f469 on master.

Copy link
Contributor

@shivam-srivastava28 shivam-srivastava28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbhoyar-uber hbhoyar-uber merged commit 7409e08 into master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants