performance optimisation: avoid map regrow calls #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
runtime/context.go
Outdated
| @@ -119,9 +119,10 @@ func WithEndpointRequestHeadersField(ctx context.Context, requestHeaders map[str | |||
|
|
|||
| // GetEndpointRequestHeadersFromCtx returns the endpoint request headers, if it exists on context | |||
| func GetEndpointRequestHeadersFromCtx(ctx context.Context) map[string]string { | |||
| requestHeaders := make(map[string]string) | |||
| var requestHeaders map[string]string | |||
There was a problem hiding this comment.
You should have a empty map. Currently it's null. If context doesn't have headers, then nil map will be returned and there are callers which directly add new keys to map.
Ex here
runtime/context.go
Outdated
| @@ -205,9 +206,10 @@ func WithScopeTags(ctx context.Context, newFields map[string]string) context.Con | |||
|
|
|||
| // GetScopeTagsFromCtx returns the tag info extracted from context. | |||
| func GetScopeTagsFromCtx(ctx context.Context) map[string]string { | |||
| tags := make(map[string]string) | |||
| var tags map[string]string | |||
There was a problem hiding this comment.
Same comment as above
hbhoyar-uber
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.